docs: update instructions#2297
Conversation
497a64e to
4eebdf9
Compare
c92e4d1 to
0a86c68
Compare
|
I just remembered something (which would make the "definition of done" for this issue a bit more work) - we should probably also include instructions for how to update to the correct versions of There's a relevant discussion here, where @spalladino provides some good insight: It might even be worth creating a new file |
|
Disabled auto-merge, in light of my comment above (sorry :) ) |
|
@iAmMichaelConnor makes sense. Will do the changes 👍 |
62c99ce to
7faa014
Compare
| Sandbox Version: 0.7.7 | ||
| Compatible Nargo Version: 0.11.1-aztec.0 | ||
| Chain Id: 31337 | ||
| Protocol Version: 1 | ||
| Rollup Address: 0x0dcd1bf9a1b36ce34237eeafef220932846bcd82 |
There was a problem hiding this comment.
Shouldn't we assert that the returned text from the command matches this? It's a bit annoying since we need to load the versions from the release-please-manifest and the noir-version jsons. Or we can just parse it manually, and use an expect.anything() for those values.
Co-authored-by: Santiago Palladino <santiago@aztecprotocol.com>
Mike is on vacations and for this reason his requests are no longer respected.
Fixes #1827
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.